Thomas Fuchs

Results 43 comments of Thomas Fuchs
trafficstars

@justinsa, @revolunet maybe it is possible to use a delegate approach in [Line 1086](https://github.com/revolunet/angular-google-analytics/blob/master/index.js#L1086) to apply different listener logic. Something like: ``` js // As default eventListener = function() {},...

True, might have overengineered that. ;-)

Now I remember why I went for delegate approach. I wasn't sure whether or not the method parameters like state are required. And using above mentioned approach would allow method...

Exactly where I was going with it. I just thought instead of adding more if statements into the code we rather go with the strategy pattern. Using the newly build...

I could prepare a PR with the delegate API without adding any new features and you can take a look. If you like it we merge it and provide API...

Layed the Groundwork in #149.

I never heard of Asana so far. I'll look into it.

Are those changes necessary for higher PHP versions? Because they would also raise the minimum required PHP version.

Docker support is obviously important and has great community interest, which is why I added Docker a few years ago. However with limited Docker experience and time the image was...

Thank you for another contribution, I am really happy to see a big org pick up the project and start contributing. Unfortunately your IDE seems to have other indentation settings,...