Toxantron
Feature/update jira plugin
Jira functionality changed to Lib(php-jira-rest-client) and some errors in the current implementation fixed
Thank you for another contribution, I am really happy to see a big org pick up the project and start contributing.
Unfortunately your IDE seems to have other indentation settings, which marks a lot of unchanged lines as changed and breaks GIT history in many places. While 4 space indentation is standard and I use it in other projects as well, for this project I would like to maintain proper diff detection.
Also I don't agree with declaring the $jiraConfiguration as part of the ControllerBase because it is specific to a single controller. Could you explain your reasons for the change, maybe I just don't see the issue with the current usage of the config?
I'm sorry that we have different IDE settings and that you have additional effort. Which IDEs or exact settings do you use? The reason for the recording was that the JiraConfiguration was not available in the Jira controller. Although the variable was accessed there, it was never "imported". That's why my idea was there in the base controller that config is imported and all controllers from there inherit according to their integration. If you have a better idea, I would be happy :)
Today I use VSCode with 4 space indentation and for new files I wouldn't mind. For existing and renamed files I would prefer avoiding indentation changes, if it's not too much trouble.
No subject, then I know for the next PR. Should I finish the indentations so that you can release the PR?
Yes please, there is also a conflict from my recent activities. As you might have noticed I found time up here in Denmark to work on a couple of older issues.
