David Junger

Results 73 comments of David Junger

Thanks for the feedback. Since you're rewriting Tar, I have a few suggestions : Streams are better for optimized handling of binary data and I/O buffers. But streams of objects...

I forgot to mention the stage-2 [proposal for `map`, `filter`, etc. on (Async)Generators](https://github.com/tc39/proposal-iterator-helpers). Makes async iterables even more attractive. Anyway, if there is indeed a general drive to make Deno...

> I'd say most usages will actually be unzipping than zipping I think so too. Unzipping is another beast entirely, though, and will never part of client-zip. When zipping, you...

Hi attez. Thank you for finding this EFS bit and submitting the PR ! There's just one thing I'd like to change before we do something we might regret, and...

Hey @attez. It's a pretty useful feature for non-ASCII Windows users and I'd like to merge it, but can't do that in its current state. If there isn't anymore activity...

> So when `useLanguageEncodingFlag` is `undefined` we would check if the filename buffer can be decoded as UTF-8? This makes sense but how that should that be done? There are...

Hello Ilya. Thank you for posting the issue. I don't have a strong objection to this. It's a very small addition and would work exactly as you said. You might...

If the Zip file is meant to be downloaded by the client, `download` should do the trick. Unless you're using a `` as I do [in my Service Worker example,...

I see. Hadn't considered that the Service Worker might have the logic to set the filename and not the client page, then it's easier to use the Content-Disposition header. Alright....

BTW, setting window.location after a button click is not ideal for triggering a download — using a `download` link to that URL, even without a filename, lets the user (and...