Marcus Farkas

Results 10 comments of Marcus Farkas

@mtrezza I can merge it sure, but you are a full collaborator. Rebase merging is enabled, can you recheck?

@mtrezza I've added the latest update requirements for npm, snyk. For node it's only 16 of the matrix since it's LTS.

> 1. leave all the Node tests mandatory for now (regardless of their LTS support, I bet there are still deployments that run on even older node versions) Done. >...

> Normally, a node behind NAT should send Keepalives to all its peers, not just to a particular one. I agree with that. However, all cluster nodes are on the...

> I think to make your use case work, we would need to check along with your proposed changes whether or not the node has a public endpoint and only...

Sounds good! I am fine with an addtional field in the CRD. So to summarize the scenario with an example: I have some number nodes in the same location/network behind...

Ah, now I got you about the second value. This looks nice! I think the array is fine here. If choosing the location directly instead of the node label, wouldn't...

Generally I quite like this approach! But I am not quite sure, if I understand the `peer` selector correctly. Does that mean one Peer CR could override a different one?...

I misunderstood, thanks for the clarification. Seems good!