Thomas White

Results 18 comments of Thomas White

@fdefalco , congratulations on the 1.7.2 release. Please let me know if you need any more information about my two PRs.

It looks as though only the median and percentile values differ. I'll double check my logic. For median, I suspect I didn't do conditional logic based upon odd vs. even...

@MaximMoinat or @clairblacketer , any update on whether this capability (especially using sqlOnlyUnionCount to generate CTE that run multiple queries simultaneously) can be incorporated into Version 2?

@MaximMoinat , I checked out the latest code from the fix_sqlOnly branch, and confirmed that sqlOnlyUnionCount is working correctly when I call it from the new codeToRun_sqlOnly.R script. Performance is...

@MaximMoinat , nevermind about help with merging. I got the merge to succeed, and am now validating.

@MaximMoinat and @clairblacketer , I submitted a different pull request from the Fork that I'm actively using. It is pull request #443 . I was able to successfully merge all...

@chrisknoll , per my read of the CDM 5.3.1 data model, visit_detail_id **is** used in relationships. All of the main clinical event tables ([condition](https://ohdsi.github.io/CommonDataModel/cdm53.html#CONDITION_OCCURRENCE), [procedure](https://ohdsi.github.io/CommonDataModel/cdm53.html#PROCEDURE_OCCURRENCE), [measurement](https://ohdsi.github.io/CommonDataModel/cdm53.html#MEASUREMENT), [drug](https://ohdsi.github.io/CommonDataModel/cdm53.html#DRUG_EXPOSURE), [observation](https://ohdsi.github.io/CommonDataModel/cdm53.html#OBSERVATION), [device](https://ohdsi.github.io/CommonDataModel/cdm53.html#DEVICE_EXPOSURE)) do...

@chrisknoll , yes, adding another checkbox for "same visit detail" would solve some of this. For example, for looking at data only from the Emergency Department, I could use either...