Tom Tranter
Tom Tranter
So I think we'd need to control power at the pack level and then work out the total pack voltage then divide power by this to get current and apply...
Have to allow power control in protocols https://github.com/pybamm-team/liionpack/blob/develop/liionpack/protocols.py
It's used in the solver here https://github.com/pybamm-team/liionpack/blob/b1a1ddbc6f607f24b3f916b8cc68f4a17980cf2e/liionpack/solvers.py#L319
And here https://github.com/pybamm-team/liionpack/blob/b1a1ddbc6f607f24b3f916b8cc68f4a17980cf2e/liionpack/solvers.py#L425
Terminal voltage can be used to divide power to set terminal current. This is set here https://github.com/pybamm-team/liionpack/blob/b1a1ddbc6f607f24b3f916b8cc68f4a17980cf2e/liionpack/solvers.py#L431 I guess using the value from previous time step should work
Yep you could loop in the initialisation step to get the right current
Use this invite https://join.slack.com/t/pybamm/shared_invite/zt-1obrjh8fr-FKm~sT8693cZnAcim5dh~A
Did you get something working for this? I ask because the script you use on the other issue uses power
Is everything you are working on in a branch somewhere I can take a look at?
Hey @OlliRuokojoki - I made some changes to the vectorized circuit solve which iterates until a certain power is within tolerance. I haven't updated any solvers to accommodate this change...