Tom Tranter

Using the actual variable limits from the dictionary instead gives the best results.  Not specifying the limits again makes the range too wide but at least shows the right...

I think there is a genuine bug. In the first screen shot you see the variation in temperature and corresponding colorbar and they have been scaled differently. ax_min and ax_max...

Yep, I’d forgotten about this until the other day On Thu, 4 Feb 2021 at 21:52, Valentin Sulzer wrote: > @TomTranter this might be a good first > issue for...

@tinosulzer I think this feature is now addressed by liionpack. I'd be happy to get the code running without experiments in PyBaMM but it might be cleaner to just leave...

Not sure that would work to be honest. The solver in liionpack is a lot more stripped down. The code you'd need to look at is `-`_mapped_step` [here](https://github.com/pybamm-team/liionpack/blob/main/liionpack/solver_utils.py)

Be good to also add a table that lists parameters with a tick against each submodel

Thanks for the comprehensive analysis and raising the issue. As this is an important paper and one of the few very well defined parameter sets I think we should attempt...

It would be handy for the non-dimensionalisation to be more visible to the user. Could you use the units in the variable name to do the non-dim automatically - I...

Yeah but did you choose different values for a good "enough" reason numerically. I could see that if the potential gradients varied differently by more than a few orders of...

I guess with the concentrations for example you would pick the max conc for each particle and then the non dim would represent the soc in a way that is...