Tom Naessens

Results 15 comments of Tom Naessens

Sorry, took a while to get the feedback processed. Let me know what you think of the changes!

> @TomNaessens , thanks for opening this, we've also ran into a similar problem. Seems like there are just some linter issues left (most of which can be autocorrected); Thanks!...

Hi @renchap, I've pushed a v3.4.0 tag & release commit on our fork: https://github.com/silverfin/shrine-google_cloud_storage/commit/e400dd1e1cd26880e7876a815ed7c27742aba5cd. Feel free to pull that in if that would help you. For this PR, let me...

Same happens for `NaN`, looks like another side effect of the same case: ```ruby irb(main):029:0> BigDecimal('NaN').round(1) => NaN irb(main):031:0> BigDecimal('NaN').round(0) (irb):31:in `round`: Computation results to 'NaN'(Not a Number) (FloatDomainError) irb(main):032:0>...

Downgrading to 3.1.1 will re-introduce the segfaults from https://github.com/ruby/bigdecimal/issues/220 (which in my opinion is less preferred than memory spikes). We'll try to downgrade to 3.1.0 until this is fixed.