dependabot-core
dependabot-core copied to clipboard
dependabot
Add max length option to BranchNamer
This PR adds a max length option to the BranchNamer and addresses https://github.com/dependabot/dependabot-core/issues/3107. Also relevant for the "... and may contain a maximum of 128 characters" part of https://github.com/dependabot/dependabot-core/issues/396.
This is a backwards compatible change and requires no configuration: when no option is passed, no truncating is performed on the branch name.
As this is my first contribution here, let me know if I missed some conventions, or if there are additional changes expected!
Approving the CI runs for first-time contributor as the PR seems headed in a generally useful direction.
Sorry, took a while to get the feedback processed. Let me know what you think of the changes!
@TomNaessens , thanks for opening this, we've also ran into a similar problem. Seems like there are just some linter issues left (most of which can be autocorrected);
@jeffwidman / @jurre, does this need more work, or do the changes look good? :)
@TomNaessens , thanks for opening this, we've also ran into a similar problem. Seems like there are just some linter issues left (most of which can be autocorrected);
Thanks! Should be fixed now 🙇♂️
Rebased, once CI passes I'll merge to main. We've been shifting to a "deploy-then-merge" strategy, but for community contributions that's not currently possible due to the way permissions on forks work, so will have to merge first. Probably won't get deployed to GitHub production til tomorrow or Friday, but that's fine in this case since the folks who need this are primarily using GitLab.