Tom French
Tom French
This branch changes the order of the jmpif as expected in the simplify_cfg pass however the issue comes up in flattening as we end up merging the values incorrectly. Master...
Agreed, we should at least understand the root cause of this first.
I've done some investigating on this and the error is due to the fact that we've moved the `return` terminator to the `then` branch rather than the `else` branch. This...
The two options for solving this then are: - Prevent a return statement from existing within the `else` branch, that is we need to turn every `if` statement into and...
> Considering the lack of any change in circuit sizes On second thoughts, this is due to the fact that at least one program has failed in each commit of...
This isn't available to people outside of aztec labs however. Can you move the relevant information into public facing documentation?
I've added an entry to ignore the legacy test.
My thinking on this is it's generally just observability. Tests become us asserting that the compiler does what we expect rather than just "working correctly". This ensure that if the...
Looks like @shoutingcatana also brought up the issue of developer documentation on how intl is done. I'd be happy to set up a CI check to ensure that the generated...
Isn't this expected however? We have 4 u64s because it's a bn254 field representation, if you provide a different `AcirField` implementation for another field modulus then it'll be backed by...