Results 135 comments of Tom French

I'm not sure if this is really necessary. Thoughts @nventuro ?

We should add the check from #1459 here as well

If a `StakelessGauge` is killed and then later resurrected then any BAL emissions from checkpoints between these two events will be locked on the gauge contract forever. This is as...

I'll fix these issues once #1191 is merged, building on top of non-merged branches is annoying.

I want to add a quick fork test to make sure that the BAL ends up in the right place before we deploy.

Hey, no worries. When I create a zkAsset, I get not only a `linkedToken` property but a `token` property as shown below. ![Screenshot_2020-05-11_11-54-39](https://user-images.githubusercontent.com/15848336/81554419-a9135400-937e-11ea-9021-52ca4b9616b2.png) I'm coming at this from the perspective...

#### RE: Add security on creation of swaps `StreamedSwap` is now formed by inheriting from `SwapProposer` and `SwapExecutor` contracts Rather than immediately initiating a swap, a user ('sender') creates an...

Should we update CI to check that these snapshots are kept up to date?

I checked and we can actually remove `CircuitBreakerParams` as we don't get stack issues if we just pass in the the 4 fields separately. This could help readability and simplify...