Thijs
Thijs
After commenting that out, we run into more issues: ``` DEBUG=true [ ESBUILD ] Patch bindings [ ESBUILD ] duckdb-browser.cjs [ ESBUILD ] duckdb-browser.mjs [ ESBUILD ] duckdb-browser-blocking.cjs ✘ [ERROR]...
I've tried running this on a linux VM, which resulted in this error: ``` In file included from /home/tishj/duckdb-wasm/build/relsize/eh/third_party/duckdb/src/duckdb_ep-build/src/main/extension/ub_duckdb_main_extension.cpp:5: /home/tishj/duckdb-wasm/submodules/duckdb/src/main/extension/extension_load.cpp:348:8: error: use of undeclared identifier 'var' var jsString = ((typeof...
I've been able to get a build working, my next step was to try to load an out-of-tree extension, this hasn't worked yet. But that's a separate issue
``` D CREATE OR REPLACE SECRET secret ( TYPE s3, REGION 'eu-west-1', KMS_KEY_ID 'arn:aws:kms:region:account_id:key/key_id', SCOPE 's3://bucket_sub_path' ); ``` > The docs were wrong, but I was able to get it...
Can we add a test with column nams containing spaces and column names that are reserved words such as "table", which have to be quoted?
@qsliu2017 probably look at `src/include/duckdb/verification/statement_verifier.hpp` To see which verifier is causing the issue, that will lead you to figuring out what the problem is that you need to fix
> Found it! `parsed_statement_verifier` transforms the already parsed `SQLStatement` to string then parses it again. > > https://github.com/duckdb/duckdb/blob/86f853d9eeae0b07cb2397f2380d2cbf81d2fbc6/src/verification/parsed_statement_verifier.cpp#L11-L15 > > > The quotes lost since the `EXCLUDE` columns are stored...
> > I'm not entirely sure I understand the issue from your description though > > Currently the exclude columns are stored in `case_insensitive_set_t`, i.e. `unordered_set`, without quotes. > >...
> hmm.. this modification is a little bit more complicated than I thought. Maybe I should make it clear at first. > > Here we need a data structure to...
I can live with the underscore version (`my_tag`), `"My Tag"` is not something I would ever use personally If this is expected behavior now, perhaps it should be mentioned in...