TagStudio icon indicating copy to clipboard operation
TagStudio copied to clipboard

[Bug]: Regression: Tags with spaces in the name can no longer be found by removing the spaces

Open Tishj opened this issue 11 months ago • 4 comments

Checklist

  • [X] I am using an up-to-date version.
  • [X] I have read the documentation.
  • [X] I have searched existing issues.

TagStudio Version

main (9.5 dev)

Operating System & Version

Windows 10

Description

Previously it was possible to find My Tag by searching for mytag, which is no longer possible. I noticed that my_tag does work, so I'm wondering if this is just an expected behavior change?

I noticed https://github.com/TagStudioDev/TagStudio/issues/112 discusses this, and links to https://github.com/TagStudioDev/TagStudio/pull/606 as a PR to fix the issue

Expected Behavior And Steps to Reproduce

Create My Tag Add it to an entry Search for mytag Find the entry that is tagged with My Tag (current behavior: it's not found)

Tishj avatar Jan 04 '25 12:01 Tishj

I can live with the underscore version (my_tag), "My Tag" is not something I would ever use personally If this is expected behavior now, perhaps it should be mentioned in the 9.4 -> 9.5 changelog when that is released (if this isn't already planned to be included)

Tishj avatar Jan 04 '25 12:01 Tishj

Yes, this is the new expected behavior. The previous behavior was the result of a bug in the parser rather than an intentional design decision - I'll make sure that this is documented in the changelog for 9.5's release 👍

CyanVoxel avatar Jan 04 '25 13:01 CyanVoxel

Just wanted to circle back to this a little, I find I'm really missing the convenience of not having to substitute spaces for tabs, so I'm likely going to add an alias for that to all tags that have spaces

Is there a possibility this can become a configuration option? To automatically add an alias to a tag that has spaces in the name with the spaces removed? opt-in ofcourse

Tishj avatar Jan 05 '25 20:01 Tishj

If it's a convenience issue, which I suppose omitting a character in place of a space is more convenient than typing an underscore, then it may be possible to add that back as an intentional feature. Off the top of my head I don't see why not, but I'm also not intimately familiar with the new parser system. Perhaps as a new feature request?

CyanVoxel avatar Jan 06 '25 03:01 CyanVoxel