Benjamin Zaslavsky comments

Results 27 comments of


                                            Benjamin Zaslavsky

[FrameworkBundle] Fix config for array of `base_uri` in `http_client`

Rebased on 6.3!

[FrameworkBundle] Fix config for array of `base_uri` in `http_client`

Edit: Edit: Still got a problem with the way base uris are defined. Configuration-wise the proposed changes seem to work. But not in the field. On a fresh install in...

[FrameworkBundle] Fix config for array of `base_uri` in `http_client`

Made an attempt just as a discussion base. Works as is, but maybe there's a better way to do it or some constraints I haven't tought about.

[FrameworkBundle] Fix config for array of `base_uri` in `http_client`

Hey there! Sorry for the ping, I know it's been a while, but could I interest you back in a review around here? @nicolas-grekas maybe, or someone else? This was...

[FrameworkBundle] Fix config for array of `base_uri` in `http_client`

Okay there have been obviously a huge mistake on my part here... Fixing asap.

[FrameworkBundle] Fix config for array of `base_uri` in `http_client`

Seems okay with the right destination branch. Sorry for the spam!

[FrameworkBundle] Fix config for array of `base_uri` in `http_client`

Test failures seem unrelated here, but any advice would be welcome!

[FrameworkBundle] Fix config for array of `base_uri` in `http_client`

Hey there! Bumping this, as it's still a missing feature. Should I create a new PR to get back in the recent ones?

Soundcheck: What We Need to Get Started

Hey! Sorry for the long silence on the matter. There are indeed a few things that are or were needed to get this started. I'm not sure, I may be...

Soundcheck: What We Need to Get Started

@SMotaal That's a pretty good idea! Please do, but please make sure those that are not here can also follow and if possible participate! (I'd really like to see this...