Tin Tvrtković

Results 444 comments of Tin Tvrtković

Sorry for the delayed response, hectic weeks at work. Let's go with `register_extra_types`. > I could start with few stdlib types, and then add support for arbitrary pluggable types to...

I can fix the current behavior in cattrs (and will), but let me ask you why is this a problem? If you have an openapi schema, you generally want to...

I agree with the consistency argument - we should fix cattrs.Converter to handle this consistently. I will fix this for the next version. However, in my view the preconf converters...

Alright, that's an interesting use case. We might make the converter an optional parameter in the future? In the mean time, you can probably dump the schema straight to JSON...

Ah, I see the issue. `configure_tagged_union` doesn't compose well with `include_subclasses` (the reverse direction works ok). You're trying to do two layers - the first layer is `A | B`,...

Howdy. I fixed this just recently: https://github.com/python-attrs/cattrs/pull/649 This issue is that the object created by the `type` statement isn't a union but a type alias. You can pass `KafkaMessageUnion.__value__`. I...

I'm totally on board with this becoming a separate package when it matures a little, definitely.

Hi. I'm on paternity leave so availability is limited. However, I just wanted to chime in that `Annotated` is too interesting and powerful for cattrs to completely ignore it. Yeah,...

Huh that looks pretty cool actually. We could support this by default. I wouldn't do the per-converter version, but focus on the global one.

Yeah I agree, if I could go back in time I'd have it be base64 by default. A configuration option for these converters sounds good.