Tin Tvrtković comments

Results 444 comments of


                                            Tin Tvrtković

Add more os calls like os.stat

@cjerdonek I guess `aiofiles.os.path`, so we mirror the sync versions closely.

export `wrap()` function for wrapping opened files

Hi! It's an interesting idea. aiofiles works by delegating operations to a thread pool, but from Googling around a little I get the idea handling stdin/stdout in an asyncio context...

Impossible to properly cancel coroutine waiting for blocking operation

Select doesn't work with regular files on Linux as far a I know.

memory leak?

This is what I get on 3.6.5, Ubuntu Bionic: ``` > python test.py Iteration 0 - Memory usage (VMS): 65.6 Mb; # threads: 1 Iteration 1 - Memory usage (VMS):...

remove readable from delegate_to_executor

Yeah there's something fishy going on here, since I see `readable()` is listed both in `delegate_to_executor` and `proxy_method_directly`. But the question is whether `readable()` is a blocking method or not?

Implement fdopen

I'm not sure, do you think it might be useful? Also is this related to https://github.com/Tinche/aiofiles/issues/8?

tempfile support

Yeah I think this would be nice. If you have the time and energy go for it. I'd say add a `aiofiles.tempfile` module with coroutines mimicking the `tempfile` module API.

StreamWriter/StreamReader api

This might be an interesting feature to support. `Write` would just append to an internal buffer, and `drain` would flush it all?

Deprecation warning on aiter

Hm. I'll take a look. Here's the relevant documentation: https://docs.python.org/3/reference/datamodel.html#asynchronous-iterators.

Unique cron executes multiple times when running multiple workers

Yeah I agree this can be solved in a much simpler way than bringing in Raft. I have a proof of concept ready to test in our codebase, then I...