Tin Tvrtković comments

Results 444 comments of


                                            Tin Tvrtković

Error with adapted_fields when subclassing attr class

Probably yes in the future, although I'm not quite sure what that API would look like exactly. In the main time, here's a way to do this now: https://replit.com/@TinTvrtkovic/cattrs257#main.py I've...

Tuple[A, B] can be structured from a list with less than two values

Not intentional. Will take a PR if it's simple to fix :)

Using make_dict_structure_fn seems to break my other structure hooks

Yeah, that's expected. `make_dict_unstructure_fn` resolves the hooks for all attributes from the given converter at the time it's created - there's no dispatch at the time it's called. So you...

Union disambiguation fails when using `to_camel` structuring/unstructuring hook factories

Hello, thanks, this might be tricky to support with the current architeture but I'll keep it in mind!

Register Iterable instead of Sequence for dumps?

Why not? Try making the change and if the tests pass, submit a PR and I'll take a look :)

Fix: GenConverter syntax errors with certain types

Thanks for this, I'm kind of stuck implementing converter.copy() atm so don't be discouraged it it takes me a while to come back to this.

Fix: GenConverter syntax errors with certain types

Looks good, can you add a small test or two and a changelog snippet?

Fix: GenConverter syntax errors with certain types

Hello, since I want to get this release out and you mentioned you'd prefer not to do tests I wrote one myself. So I'm merging this in now. Thanks!

Syntax Error in generated code

Thanks, I'm aware of this (there's another, similar issue), it's on my radar for the next version. Just out of curiosity, if you change the line to ``` raise IterableValidatoinError("While...

Syntax Error in generated code

Yeah, the play might be to just escape any single quotes in the repr.