Tim Clephas
Tim Clephas
Ahaaa, I did not know that split bagfiles actually ended up in the same directory. (Sorry, should/could have verified). But this is kind of strange right? The 'total' bagfile is...
I took the liberty of mimicking this implementation: https://github.com/ros/diagnostics/pull/197, as that has proven itself in production for a few years now. As a bonus, it re-uses the `publishData` function such...
Happy new year everyone! As this PR is not backwards compatible with changes as of 2023-12-05, I guess it might be preferred to get this in quickly?
I've added the test, ready for a re-review
Subtle ping :slightly_smiling_face:
Since this is technically a breaking change, I would like to have this in rolling before Jade is split off. @ct2034 are you happy with the added test?
Aaaand we missed Jazzy :crying_cat_face: Can we please get some traction on this now? Or have at least some comments on what needs to be changed?
This would be easy to make backwards compatible by checking if the input is a list. If not -> convert to list with single element. Without this I don't see...
Great, I think this is better :slightly_smiling_face: But I'm going to disappoint you here, I don't have anything to say in this repository. And since only 1 PR got merged...