Tim Clephas
Tim Clephas
#152 was an issue, so technically there were no changes. But yes, the `saveSvgFile` was based on the suggestion there.
This branch went out of date. I rebased it.
Now that #186 has been merged (thank you) this one can have a go as well. It's especially useful for automating the documentation process. Like in pre-commit hooks or CI...
subtle ping :slightly_smiling_face:
Note, I didn't touch the other `except KeyboardInterrupt:` statement as it actually does work when controllers are successfully loaded.
Good question! That doesn't have the same check in it. Coming to think of this, since asking for permission instead of forgiveness is an antipattern (and actually breaks stuff: https://github.com/ros-controls/ros2_control/issues/1200)....
I need some assistance here. CI is failing on: ``` Could not find a package configuration file provided by "test_msgs" with any of the following names: test_msgsConfig.cmake ``` But I...
I dropped the test. As it was testing if false inputs gave no result. It could be written if a warning was issued, but that would mean parsing stdout or...
Regarding backporting, keeping the original timeout with the option of setting it to indefinitely makes sense! However, I strongly opt for this to be the default in future releases. We've...
Yes, but defaults are very important. I fail to grasp how a node printing once and failing in the startup noise is a more clear message than an error/warning being...