Timothy Gu
Timothy Gu
While I'm in principle for this change, the resultant IDL files in #856 now look like a strange and jarring mixture between the C/JavaScript style and the more concise Rust/WASM...
I think @domenic wanted `(… or undefined)` as type of an attribute. See https://github.com/whatwg/webidl/pull/906#issuecomment-670724983. Though in this particular case, I feel it would better adhere to convention if it instead...
HTTPHeaderString could be a bit confusing. `"\x04"` is not a valid character in an HTTP header, but is a valid ByteString value.
> But a leading ? has no meaning in the POST payload and *should not be stripped*, and if that behavior cannot be turned off Always prepending a `?` before...
> Is `URLSearchParams` just a drop-in replacement for the `querystring` module or are there other changes we'll need to make in order to use it correctly. No, `URLSearchParams` has a...
> you cannot just drop in the `URLSearchParam` class depending on Node.js version without also adding in routes to convert the return value back into a plain object such that...
[ICU](http://icu-project.org/) is a piece of software written in C++, that Node.js and V8 [are already using](https://github.com/nodejs/node/blob/master/doc/api/intl.md#options-for-building-nodejs) to support many Unicode- and internationalization-related things. The PR I linked will make use...
> I assume that meant that by default, most people will only have the "small-icu" installed, is that right? Yes. > So then this module will have to use that...
In the mean time I've finished up https://github.com/nodejs/node/pull/14151, which when added to a v8.x release should fix the original bug. EDIT: the pull request just landed in Node.js. It will...
@stevenvachon `whatwg-url`'s `URLSearchParams` is pretty slow.