Timothy Gu

Results 227 comments of Timothy Gu

_child_'s previous sibling is saved, but not _node_'s. The first mutation event results from step 13 of [replace](https://dom.spec.whatwg.org/#concept-node-replace) > Insert _node_ into _parent_ before _referenceChild_ with the _suppress observers flag_...

@annevk Yes, definitely feel free to play around. Tests are all there, and you can change test exceptions in the [to-run.yml](https://github.com/jsdom/jsdom/blob/master/test/web-platform-tests/to-run.yaml) file (look for 754 and 813) for a list....

Sorry, it looks like I have gotten myself confused. The correct patch should be the following: ```patch diff --git a/lib/jsdom/living/nodes/Document-impl.js b/lib/jsdom/living/nodes/Document-impl.js index 94f8d484..3b486d84 100644 --- a/lib/jsdom/living/nodes/Document-impl.js +++ b/lib/jsdom/living/nodes/Document-impl.js @@ -816,7...

For Node.js to accept (and implement) this, the `on()` method name must be changed, given that the Node.js `EventEmitter` class has `on()` as an alias for `addEventListener()`. People who program...

> Node could switch on the number of parameters provided to the on() method. The IDL proposed in the OP allows a second `options`-style parameter. But I'd also like to...

To be clear, anything other than `on` would be fine with me. I’ll leave y’all to determine what’s best other than that :)

I think that reverting would be good, especially since none of the major browsers have implemented it. I'd be glad to use jsdom as a testbed for any such change.

I think the convention is `.map` but I don't see a reason not to.

@RobLoach said: > - [ ] [Jade](http://jade-lang.com) - Put together a [Jade filter](http://jade-lang.com/reference/filters/) We are planning on completely switching to jstransformers in Jade, so: ``` jade :supermarked ## Heading 2...

We at @pugjs are using jstransformers for Pug 2.0.0, which supports everything from 0.10. It'd be a shame to see a module we use not support the Node.js versions Pug...