Tim Hutt
Tim Hutt
In the other PR to update the CLI we've removed short options so when you rebase on that I'd just remove it. Also I don't think having a single flag...
Yes, if we want to support loading executables at arbitrary offsets. I don't know how much demand there is for that though. What was the original motivation for this?
Can you explain what this means?
Looks pretty good. I think we probably don't want to convert things to strings though. Now that we use a generated header maybe we can use the actual generated types?...
> do we have a comparison table between C and sail and sail-riscv? like int in sail for sail-int for C. There are three options: * `fbits` (alias for `uint64_t`)...
Yeah I also don't like fprintf. We could use iostreams but they also kind of suck. `std::print` is much nicer but only available in C++23. Maybe we just wait a...
I've used spdlog in the past. It's pretty good but has compilation time issues. For the actual formatting it uses `fmt` which is basically what C++20/23 copied for `std::format`. I...
It's not a big problem really. `std::print`/`fmt::print` is just a bit easier to use and more difficult to get wrong. I would say it's fine to leave it for now...
Should we remove the entire `prover_snapshots` directory? Or move it to another repo at least?
I'll close this since Alasdair removed the `riscv-ast-raw.txt`. Maybe I'll remove the whole directory at some point... (or if someone else wants to feel free!)