Add callback for pt walk

[Arielfoever]

fix #1356

[github-actions[bot]]

Test Results

2 115 tests  ±0   2 115 ✅ ±0   20m 50s ⏱️ +10s     1 suites ±0       0 💤 ±0      1 files   ±0       0 ❌ ±0 

Results for commit 7591875b. ± Comparison against base commit d7b474b9.

:recycle: This comment has been updated with latest results.

[Timmmm]

Looks pretty good. I think we probably don't want to convert things to strings though. Now that we use a generated header maybe we can use the actual generated types? zPrivilege and so on.

[Arielfoever]

I think we need to take into meeting due to divergence from #1372

[Arielfoever]

We will add an option ptw-trace.

[jordancarlin]

We will add an option ptw-trace.

It should be --trace-ptw to be consistent with the other trace related flags.

[Arielfoever]

We will add an option ptw-trace.

It should be --trace-ptw to be consistent with the other trace related flags.

I really hate add a lot of options for trace. we should have some modern log system that support subscript.

Go https://github.com/riscv/sail-riscv/issues/1204

[Arielfoever]

Looks pretty good. I think we probably don't want to convert things to strings though. Now that we use a generated header maybe we can use the actual generated types? zPrivilege and so on.

A little off topic - do we have a comparison table between C and sail and sail-riscv? like int in sail for sail-int for C.

[Timmmm]

do we have a comparison table between C and sail and sail-riscv? like int in sail for sail-int for C.

There are three options:

• fbits (alias for uint64_t) - when the type's size is statically known.
• sbits - when it's not statically known but is statically known to be <= 64 bits.
• lbits - if neither of the above applies.