Tim Hutt

Results 626 comments of Tim Hutt

Yeah probably worth still running Pylint. Unfortunately the only time I tried to add a lint to it (to detect accidental concatenation of strings) I found that it was impossible...

Possibly the same as #182 though that says it has been fixed...

What's the issue that downloading it causes?

Ah makes sense. I think it would be worth explaining that in the comment.

Ah amazing! And wow you're right that is quite the PR!

Ah interesting. I didn't write this code though unfortunately and have never written a proc macro. I *think* [this function is responsible](https://github.com/bytecodealliance/wasmtime/blob/7f8370a5fa37fe11c7a4581230cd09932656ea8d/crates/component-macro/src/bindgen.rs#L23). It does seem to return `Span::call_site()` for errors,...

Sorry, this is getting a bit off-topic but it would be great to improve this in `wasmtime` anyway. I couldn't really find any documentation for this stuff so I asked...

Actually, looking at this particular proc macro it unfortunately generates a big string and then turns that into a token stream, so annotating it properly would be difficult... but I...

Ah yeah and I don't think `WASMTIME_DEBUG_BINDGEN` helps r-a in this scenario either, because it just allows writing the code to an external `.rs` file; you still can't use `Span`...