Tim Hutt

Results 629 comments of Tim Hutt

I dunno, that means we'd have to deal with OCaml again... I'd rather just have more regular releases of the Sail compiler.

> Please don't tell me you want to squash all the patches. :) Nope! > I think Github supports it (Git alone does), both rebase and merge-commit PR resolution should...

Where did we get to on this? It looks like the remaining changes in this are fairly small and nice so maybe we can rebase it and get it reviewed/merged?

> because we started putting mstatus into a lot of callbacks, which made dynamic computation of the dirty bit awkward. Aw I thought that was a good idea. Can't you...

> the runtime overhead of the computation That's going to be completely insignificant. Mstatus statically fits in 64 bits so it will be inlined to just a few simple instructions.

Hmm most of those use `c_emulator/riscv_sim_RVxx` though, which wouldn't work anyway since the executables are generated in a build directory now. The other wrinkle is that the name is going...

[Specification is here](https://riscv-specs.timhutt.co.uk/spec/20240411/priv-isa-asciidoc.html#smepmp)

Ah looks like there's a small conflict that needs to be resolved...

Hey, sorry I'm probably not the best person to review this since I have roughly zero knowledge of the debug/triggers spec. I can review the low level Sail syntax if...

Ah we just need to add ``` cmake_policy(VERSION 3.20...3.31) ``` I think that should work anyway. The `cmake_policy` documentation is really badly written.