TimMJN

@peternewman Thanks for the review! I've processed most of your comments. I don't think the library should enforce using unique manufacturer-specific PIDs, but perhaps @mathertel could add a remark on...

To do: add support for cold reset using RESET_DEVICE 0x01 ``` void(* resetFunc) (void) = 0; resetFunc() ``` (leave the warm reset RESET_DEVICE 0xFF to be user-defined)

RDM test results: ``` OLA RDM Responder Tests GetMaxPacketSize: FAILED Check if the responder can handle a packet of the maximum size. GET: uid: 0987:2012fb3b, pid: DEVICE_INFO (0x0060), sub device:...

Seems like we should add a catch for Set on the device label, return nack Write protected. The first fail is related to https://github.com/mathertel/DmxSerial2/issues/46?

found the problem with device labels. Writing up to 32 characters to EEPROM takes too long to send the response in time. I've moved the `_saveEEPRom` call after the response...

Test output: ``` OLA RDM Responder Tests GetMaxPacketSize: FAILED Check if the responder can handle a packet of the maximum size. GET: uid: 0987:2012fb3b, pid: DEVICE_INFO (0x0060), sub device: 0,...

> No, there's little point implementing a read only device label, but I think you've got to the bottom of that. You're right, I was misreading the test output. >...