Tim Diekmann

Results 73 comments of Tim Diekmann

The plan is to remove `attach_printable` when `specialization` (`min_specialization` does not allow specialization on traits) has been stabilized. I don't think it's possible to specialize on two different types, if...

Not going to merge this right now because 1. We found a memory leak with is most probably related to shared memory 2. Python probably needs unmapping of the re-allocated...

The PR fails at the CI with an error, which is very very likely because arrow-rs have different expectations than JavaScript's arrow implementation. I marked this as blocked by [Move...

Weird, the `test` job is failing while the `bench` job is passing 🤔

I triggered a [new run](https://github.com/hashintel/hash/runs/6975191592?check_suite_focus=true). Maybe it was a very unlucky spurious failure (somehow the [test was terminated by SIGKILL).](https://github.com/hashintel/hash/runs/6974724295?check_suite_focus=true) I will investigate this later.

It appears that we have a memory leak in hEngine and this is accumulating when running multiple tests. This PR is ready to be merged but my worry is, that...

> This PR also introduces an ASCII and a hook version and is currently under hook/json As mentioned before, let's *not* provide a JSON hook. If the user wants to...

Hmm, It's a bit hard to follow. Could you quickly summarize the impact on the public API?

That's pretty impressive! I haven't really looked at the code yet, but I will definitely do it soon! I'm a little worried, that we now have a `Context` trait and...

> Should I copy the minimal code required (suboptimal) or relocate these structures to another file? (the are currently located with the trait implementation in `fmt::hooks`), if so, to which...