Tim Brooks

Results 6 comments of Tim Brooks

> LGTM2 but note that we're not including the AlreadyClosedException (plus stack trace) in the log message. Not sure of the context but maybe that'd be helpful? @DaveCTurner The exception...

> But I assume you'd like to log the specific shard ID/state, right @tbrooks8 ? Yes pretty much just trying to catch in a face of an unexpected failure.

When I original wrote the design document with @ywelsch I had called the mode "direct" or "simple" mode and it accepted a list of socket addresses where we open direct...

I imagine it is because the way a rejected channel is closed on windows breaks the assertion for caught exceptions in the client. ```java @Override public void exceptionCaught(ChannelHandlerContext ctx, Throwable...

> RefCounted instead? That works. I made that change.