Steve Dougherty
Steve Dougherty
Can you remind me why this is a single Hash class that supports multiple hash types instead of an interface and multiple implementing classes? I might have asked this before...
I get failing tests: ``` [junit] null [junit] junit.framework.AssertionFailedError [junit] at freenet.crypt.HashResult.(HashResult.java:30) [junit] at freenet.crypt.HashTest.testVerifyHashResultByteArrayWrongSizeMac(HashTest.java:333) ```
I've merged this into a `HashingAPI` branch for inspection.
Thanks! 1471 is settling down for release, so we can look at merging this after its release. 1471-pre3 - hopefully its last prerelease - is scheduled for this weekend. On...
When I (slightly changed the contrast so it would let me and) resaved the image with Windows' Photos editor, it stopped happening:  So that may make it relevant that...
You're correct! It turns out both that my version of GIMP is old, and that this doesn't happen with 2.10.32. Thank you!
@toxicbubble Good idea - I just made a fork and [did that](https://github.com/Thynix/ShadowFox#installation-and-updating). I'll look into getting the updater to automatically do it later this week.
@ArneBab You mentioned in your mailing list post about 1495 that this blocks release. Is that because you want to build the release with GitHub CI instead of locally?
@maldil You say hopefully it'll improve performance - it sounds like you didn't test it?
I'm not clear on whether this is hosted elsewhere, but `beatsaver.com` is using another fork, and [that one implements preview](https://github.com/elliotttate/beatsaver-laravel/blob/449ce02b47da0825c417725bfaccd537ee6e3de0/resources/views/themes/bulma/components/song-detail.blade.php#L20)