Steve Dougherty
Steve Dougherty
Any word on this?
@toad Do you plan to address the comments? If not someone else can volunteer to do so.
Whee, more conflicts.
What's the different between `byte[]` and `ByteBuffer`? The former seems to be used in KeyGenUtils a lot, and the latter here. Why?
@unixninja92 ByteBuffers seem higher-level. Given the option between byte[] and ByteBuffer are ByteBuffers preferable?
What's remaining on this?
If you're already squashing, would you be willing to bring the commit messages up to [the commit message standards](https://wiki.freenetproject.org/Coding_standards#Commit_Messages)? If they're unclear please ask. Not doing it and getting this...
@toad Were there actually serious bugs? @nextgens seemed to think that it was more that the API did not match your expectations.
It's close. The standards (won't be merged until at least someone else says they're happy with them - do they seem reasonable to you?) are [here](https://github.com/freenet/fred/pull/338/files#diff-6a3371457528722a734f3c51d9238c13R45). Looking at the standards,...
Thanks! I'll have to make a 1468 release branch in order to merge this to next, but I plan to do so ... soon. Maybe tomorrow - my schedule is...