Yakup Koray Budanaz

Results 31 comments of Yakup Koray Budanaz

I have updated everything according to the comments

I have tried to apply every comment you have mentioned, I will add the comment for the functions now and make another commit. Other than that I have used the...

I am glad to hear that, right now I have some other urgent tasks to attend to, I will continue with the proposed fixes for the PR as soon as...

When I saved it also trimmed some trailing whitespace (lines that only have whitespace, it is for the better I think)

I also need to check why the param type can be none sometimes (some tests failing)

There is one issue that I am currently trying to solve. I can know change the map parameters' types, and can set them to be for example int, but I...

> Good addition, thank you! Two things are missing: > > 1. My comment on symbols_defined_at (which should be computed as seldomly as possible) > > 2. Missing unit test...

Since there is no auto type, it is hard to create one that fails due to auto. When I tried with auto, having auto I = 0; I

> I would not use IN_size (i.e., a throughput connector), maybe use just `size`. About the connector, we can also read the size, then this will be "OUT_size" I had...

> > > I would not use IN_size (i.e., a throughput connector), maybe use just `size`. > > > > > > About the connector, we can also read the...