ThrawnCA

Package modified date should not change when only resources are changed

8

**CKAN version** 2.9 **Describe the bug** Package "metadata_modified" timestamp should not change when resources are changed or reordered. **Steps to reproduce** * Create a dataset with multiple resources * Swap...

False positive on URV_CHANGE_RETURN_TYPE with constrained code

2

URV_CHANGE_RETURN_TYPE sometimes doesn't take account of all the constraints that may exist on code. For example, when creating a custom Hibernate UserType, we have code like the following: @Override public...

UTAO false positive with complex boolean expression

4

I have a unit test to ensure that a utility class is properly defined (private constructor, all methods static, etc), and one of the assertions is triggering UTAO_JUNIT_ASSERTION_ODDITIES_USE_ASSERT_NOT_EQUALS, but I...

CE_CLASS_ENVY for heavy use of third-party code?

1

What is the best approach to take when fb-contrib reports CE_CLASS_ENVY for our extensive use of methods from a third-party library? Just ignore it? Obviously the suggested "add this method...

Detector suggestion: Expecting Error in unit tests

2

Tripped myself up recently when unit-testing some code that is meant to handle a subset of `java.lang.Error` (specifically, it's a scheduled job that shouldn't completely kill the scheduler if a...

Detector idea: assembling Pattern from unescaped inputs

1

I came across an error recently that would be nice to have a detector for, although it would need to be pretty restricted, because false positives would be easy. I...

Test classes do not need equals or hashCode

3

Our test classes frequently have fields, eg for mock injection, but as far as I can tell, there is no reason for them to implement `equals` or `hashCode`. `IMC_IMMATURE_CLASS_NO_EQUALS` and...

Apparent false positive on PCAIL_POSSIBLE_CONSTANT_ALLOCATION_IN_LOOP

8

We're hitting `PCAIL_POSSIBLE_CONSTANT_ALLOCATION_IN_LOOP` in code that, as far as I can tell, is not able to allocate the relevant variable outside the loop. public List getTransactions(TransactionSearchCriteria criteria) throws Exception {...

**Describe the bug** When creating a mail session, `EmailServerUtil` does not specify the `mail.transport.protocol` property, as expected according to the [Session javadoc](https://javaee.github.io/javamail/docs/api/javax/mail/Session.html#getInstance-java.util.Properties-javax.mail.Authenticator-). This might work in some environments, depending on...

**Describe the bug** PWM v1.9 build fails due to altered core-js dependencies (see https://github.com/zloirock/core-js/blob/master/docs/2019-03-19-core-js-3-babel-and-a-look-into-the-future.md). PWM v1.9 cannot be built. **To Reproduce** Steps to reproduce the behavior: 1. Check out PWM...