TW

The [All about JSON](https://borgbackup.readthedocs.io/en/stable/internals/frontends.html#archive-differencing) page needs an update because of #7335.

ideas for using the flags

3

The ChunkIndex is a mapping `256bit key --> (32bit flags, 32bit size)` since #8513. The user flags are: - F_USED, meaning the chunk is referenced / used. this is used...

borg create: try to speed up unchanged file processing

2

Early borg used to work filepath-based to deal with the source files (stat, open, read, xattrs, acls, fsflags). That was problematic due to race conditions and thus was changed in...

iirc, borg and borgstore don't use urlunquote yet. but having spaces or other special chars in a path might be not that unusual and would require quoting / unquoting, e.g....

review "assert" usage

13

See there for the problem description: https://community.sonarsource.com/t/feature-python-assert-should-be-consider-harmful/38501 TL;DR: for now, do not run borg via `python3 -O` or with `PYTHONOPTIMIZE` set. In the code, `assert` should be only used for:...

review / refactor python file object vs OS-level file handle usage

1

for reading the backup source files, borg master branch tries to work based on an **open file** as much as possible (not working with **file names** to avoid race conditions)....

test_with_lock sometimes failing

2

``` openbsd7: ________________________________ test_with_lock ________________________________ openbsd7: [gw0] openbsd7 -- Python 3.10.13 /vagrant/borg/borg/.tox/py310-none/bin/python openbsd7: openbsd7: tmp_path = PosixPath('/tmp/pytest-of-vagrant/pytest-0/popen-gw0/test_with_lock0') openbsd7: openbsd7: def test_with_lock(tmp_path): openbsd7: repo_path = tmp_path / "repo" openbsd7: env =...

freebsd 14 test failure in test_multiple_link_exclusion

4

``` freebsd14: ______________ DiffArchiverTestCase.test_multiple_link_exclusion _______________ freebsd14: [gw12] freebsd14 -- Python 3.10.16 /vagrant/borg/borg/.tox/py310-fuse2/bin/python freebsd14: freebsd14: self = freebsd14: freebsd14: @requires_hardlinks freebsd14: def test_multiple_link_exclusion(self): freebsd14: path_a = os.path.join(self.input_path, 'a') freebsd14: path_b =...

windows: birthtime and ctime

2

From: https://docs.python.org/3.12/library/os.html """ Changed in version 3.12: st_birthtime[_ns] is now available on Windows. """ """ Changed in version 3.12: The st_ctime attribute of a stat result is deprecated on Windows....

https://man7.org/linux/man-pages/man3/acl_to_any_text.3.html Compared to `acl_to_text`, we can: - get the uid / gid instead of the names - avoid a gazillion more or less expensive, uncached lookups inside libacl for the...