TW
BTW, you are working in your master branch. Usually you should first create a feature branch for the feature you are working on, that works much better in the end....
@francoo98 writing tests seems a bit tedious at first, esp. if you are new to it, but long term it can save countless of hours of manual testing (and/or countless...
Looks like there is some conflict with master branch, please resolve. (That will also trigger the tests to run again. Seems like the last test run had some unrelated issue.)
the linter is still unhappy, see github checks. you can run `black .`and `tox -e flake8` locally to detect and fix such stuff early.
Ehrm, that code is wrong. I meant `.removesuffix()`, not `.rstrip()`: ``` hashing_time = float(hashing_time.rstrip(" seconds")) ``` Please fix all similar places in your PR.
@francoo98 thanks for the PR, it's merged now!
Well, guess this is by design. And if it says "sh: rules apply", that does not imply that you can use the other patterns also. But I see your point,...
@Gu1nness PRs welcome. Try to reuse code from existing patterns matching, if possible.
@preetisi sure, it is still open. maybe first think about how to solve it best, discuss it here, implement tests + code, do a PR early.
Yeah, naming it "glob-..." when not (only) doing globbing is maybe a bit strange. As we'll break some stuff anyway in borg2, we could also rename that. Guess that would...