Thomas

Hi @dgpv, this looks simple enough to tip my toes in without messing up, so you are referring to: https://github.com/bitcoin/bitcoin/blob/80c8a02f1b4f6ad2b5c02595d66a74db22373ed4/src/primitives/transaction.h#L219 in this library it means raising an exception at around...

Hi, thanks! I gave it a quick try yesterday evening, that approach breaks 6 tests, I think the reason lies in the comment: "...transactions which have zero inputs: they are...

Hello, so after reading more in depth, it looks to me the tests want exceptions raised from CheckTransaction https://github.com/petertodd/python-bitcoinlib/blob/ebc85bf3f75508aba92d3a94cd024670bf25be76/bitcoin/core/__init__.py#L784 To do so, I've added "markerbyte" and "flagbyte" to the class...

Hello, sorry got stuck on something else. I've followed your advice, used only flagbyte, and just sent the pull request with the simple modifications. isn't "x^=1" the same as "x...