Emelia Smith

Results 471 comments of Emelia Smith
trafficstars

Whilst this seems useful, perhaps it'd be better to have a convert-graphql-schema tool instead, which works purely on local files?

Does this then change later code where we read from both `argv['j']` and `argv['json']`? Do we only need to read from `argv['json']` after this change?

So, I managed to get this working with the following git hook: ``` #!/bin/sh if [ "$LEFTHOOK" = "0" ]; then exit 0 fi debug () { if [ "$LEFTHOOK_DEBUG"...

As a further note pre-push and post-push are the only two that can receive stdin when executed by git, however, git isn't always going to give you information via stdin,...

I suspect this might be related to something I've just seen which is if you try rebasing the branch in which you added lefthook to reorder commits, then lefthook creates...

@Arkweid the specific error I was seeing was because of the auto-install functionality: https://github.com/Arkweid/lefthook/blob/7de5f82358b969bb4ae49096659665229e4dc8c8/cmd/install.go#L66-L69 Should I create a new issue for this?

The config file seems to be generated by these lines of code: https://github.com/Arkweid/lefthook/blob/7de5f82358b969bb4ae49096659665229e4dc8c8/cmd/install.go#L66-L69 As the git hook that is generated contains a call to `lefthook install`: https://github.com/Arkweid/lefthook/blob/7de5f82358b969bb4ae49096659665229e4dc8c8/cmd/add.go#L64-L76

I agree with @timbl and @kjetilk here β€” I'm not sure what sending a notification to an inbox is intended to achieve, and I'm concerned that this could lead to...

> > I'm not sure what sending a notification to an inbox is intended to achieve > > The notification is intended for the attention of the receiver, e.g., 403...

@csarven I'm hearing what you say, but I still think we should be very deliberate in what this is intended to have as an outcome. i'd also ask: if a...