ThetaSinner

Results 306 comments of ThetaSinner

What has changed since the previous review? I've unresolved the non-trivial comments from and I'll resolve them as I look for the code changes that resolve them. That's a helpful...

I know the implementation doesn't match the ticket the way it's written, but if there are any stray copies of large data sets or missing database indexes that affect gossip...

> the included op count, space hash Oh yes actually, we should add these now. I could see them being relevant in reporting immediately. The others I *think* can wait...

> especially since OpType is only a string here. I've done this so that the PR can be backported to 0.3, which is where I need it. We can look...

Superseded by Kitsune2 which will implement this

I did commit to doing it at some point because I know it was asked for. I now have enough confidence in the Kitsune2 API and knowledge of some of...

This function is being actively used as a way to query the chain. I think we should split the documentation into two pieces. - How to query another agent's chain...

Some of the code documentation for the types exposed to the HDK could be improved. I suggest including that in the ACs.

No longer actively depending on `coreDev` to run tests, I'm going to close this unless somebody raises it again

That's interesting. So you could advertise that you're trying to achieve a full arc but that you are acting as an authority for a smaller arc or even 0. Then...