Raphael Erik Hviding

Results 16 comments of Raphael Erik Hviding

Sounds good, I've opened #217 to try and at least fix the DQ bit bug in the short term. Can you specify what you mean by wanting "to use this"...

With #217 merged I think this issue is mostly resolved.

This was a good suggestion. I've added the check against the ONEFEXP keyword, as well as adding a force option in the function.

Sounds good, I've submitted PR #207 to address the short-term issues, but will continue testing against this PR and keep this updated.

This PR now passes all CI checks and has been tested on real data to ensure it gives the same results.

This is a good point, we actually maintain greater compatibility with this change. The "new" Polynomial syntax has been around in NumPy since 1.4, which is over 10 years old...

I've just pushed the change requiring NumPy >=1.4. There are likely other parts of grizli that would require newer NumPy versions, but this is a start.

Scipy 1.6 introduced the new scipy.integrate.

I agree that the user should specify what the fallback is. However, I thought that was the role Grism Reference Filters dictionary. If that's not the case, perhaps we can...

I've opened #210 to at least add a message to the user if the corresponding direct image can't be found. I'm curious as to why the Grism Reference Filters dictionary...