Nathaniel Dsouza

Results 86 comments of Nathaniel Dsouza

According to https://developer.android.com/training/notify-user/channels To register a notification channel, this code is executed: ``` private void createNotificationChannel() { // Create the NotificationChannel, but only on API 26+ because // the NotificationChannel...

Haven't gotten a chance to attempt implementing this fix yet, though it seems promising. Will update once I've tried it.

Follow up question. Once the channel is implemented, how do you specify the channel when sending the notification?

Code works to register a channel. Now need to figure out how to send a notification to a specific channel.

I've made a [fork](https://github.com/TheRealNate/push/blob/master/lib/server/push.api.js) for this repo with @da314pc's changes. I'll try testing it asap.

Would this be correct usage? ` Push.send({ from: 'push', title: 'Hello World!', text: 'Lorem ipsum', android_channel_id: 'testchannel1', query: {} }); `

It seems to be removing the argument android_channel_id before it gets to the code around line 309

Done, https://github.com/TheRealNate/push/blob/master/lib/common/notifications.js Testing these changes. Is it enough to allow the argument?

I'm no longer getting the error message, so the channel id seems to be making it to the code in push/lib/server/push.api.js, yet notifications still don't seem to be working.

The logs do confirm when `Push.debug=true` that it's reaching: ``` Push: Sent message "Hello World!" to 0 ios apps 8 android apps ``` And ``` ANDROID: Result of sender: {"multicast_id":xxx,"success":1,"failure":0,"canonical_ids":0,"results":[{"message_id":"xxx"}]}...