Brooks Rady

Turns out, `Report` *really* doesn't want to be an `Error` or `Diagnostic`...

2

Failing some context tests, I'm pretty sure because `self.wrap_err(msg)` creates a `context_chain_downcast` table, whilst the `Report::from_msg(msg, self)` that it's impl clashed with only creates at `context_downcast`. I messed around and...

Fixes #369 The culprit was: https://github.com/zkat/miette/blob/ea4296dacec3b0e4762281d9d115c1bd69ecfac3/src/eyreish/error.rs#L728 In conjunction with: https://github.com/zkat/miette/blob/ea4296dacec3b0e4762281d9d115c1bd69ecfac3/src/eyreish/error.rs#L531-L537 Which converts a `Box` into the `Box`, hence the resultant object ends up with the empty `Diagnostic` impl defined above!...

Converting a `Report` to a `Box<dyn Diagnostic>` wipes all `Diagnostic` information

1

I suspect this is a super subtle issue in the crazy vtable code, but here is a relatively compact reproduction of the issue: ```rust use miette::{miette, Diagnostic, LabeledSpan, Severity}; fn...

Is there a reason that `Report` doesn't implement `Error` and `Diagnostic`?

2

I've maybe not done enough thinking on this yet, but it would seem that https://docs.rs/miette/latest/miette/struct.Error.html can be converted to all sorts of `Error` or `Diagnostic` trait objects, but doesn't implement...

feat!(blanket_impls): impl `Diagnostic` for &T and Box<T>

3

Partially addresses #366 Brings things in line with best practices as described in "Rust for Rustaceans" when it comes to "Ergonomic Trait Implementations" in Chapter 3. Practically means that people...

Failing tests with `--all-features`

1

It looks like there is currently a test matrix that's testing the `fancy` and `syntect-highlighter` features as part of the CI, but out of curiosity I ran `cargo test --all-features`...

Default parameters don't accept `const` values

1

### Describe the bug I've written a bit of code like this: ```nu const x = 'cool/stuff.txt' def main [file = $x] { # ... } ``` But got the...

Add KDL Language

1

## Language name KDL: https://kdl.dev/ ## URL of example repository https://github.com/kdl-org/kdl ## URL of syntax highlighting grammar Grammar Spec: https://github.com/kdl-org/kdl/blob/main/SPEC.md Implementation: https://github.com/tree-sitter-grammars/tree-sitter-kdl ## Most popular extensions Just `.kdl` currently ##...

Add `fn zip_longest`

1

There is a function version of `zip_eq` already, but it appears that `zip_longest` is still only available as a method? Let me know if you think this is a worthwhile...

### Summary I could just be missing something, but it doesn't yet look like petgraph provides an algorithm for finding k-edge-connected components! ### Motivation Well, it's the graph algorithm I...