Brooks Rady

Results 42 issues of Brooks Rady

Bringing in line with https://rust-lang.github.io/api-guidelines/interoperability.html#types-eagerly-implement-common-traits-c-common-traits ! Left out `Display` and `Default`, since those don't make quite as much sense here, though I'm sure someone could make a case for Default...

Very simple change, but this brings with it some nice fixes the the GraphicalErrorHandler in `miette` — it also fixes a bug currently present where line and column numbers are...

Most of this is just the commit description, but here's a picture of the sort of diff this change produces on my end: ![image](https://github.com/tailhook/knuffel/assets/6251883/d00d58fc-526b-4be1-89e9-ebf958df82f4) You can see that I used...

Hi @tailhook ! This is a slightly bigger change than my other PR, but fundamentally just enables me to add a `non_empty` tag to `#[knuffel(children(...))]` attributes, guaranteeing that at least...

Hi @tailhook! Just a simple change exposing a couple of AST fields that were previously only `pub(crate)`. When it came to `Literal::Bool`s and `Literal::String`, their internal fields were already available,...

A blocker for 1.0.0, I'd imagine, but shouldn't be too hard to fix! I found Not / Neg first: https://docs.rs/derive_more/1.0.0-beta.6/derive_more/derive.Neg.html But it seems to be a broader trend when things...

help wanted
docs

I'm not sure if this is just a configuration issue on my end, but `rust-analyzer` seems convinced that the only version of traits like `Display` or `Into` come from this...

bug

I'm not sure if this one falls in scope, but it would be lovely to get the kinds of results you get from https://github.com/iai-callgrind/iai-callgrind (a maintained fork of the original...

enhancement

Similar to what criterion does, but I think a useful starting point would just be a ±% change in times between runs (if it's determined that the two runs differ...

This PR builds on PR #367! Merging this should be equivalent to merging both! You can now pass a `&dyn Diagnostic` (as before), or a `Report` (or `&Report`, `&mut Report`,...

breaking