TheJonny
TheJonny
in [16d1080](https://github.com/ihrwein/enum-display-derive/pull/11/commits/16d108091214a0717b6ce226fee330f8fce83fd9) I had to add an `edition` to `Cargo.toml`, so that `core::fmt::Display` is found. If you want to support older compilers: 2018 does also work, 2015 does not.
> rmfakecloud could run either on HTTP and HTTPS, so deprecating `STORAGE_URL` in favor of a variable with less information is awkward. > > Moreover, you can use the `net/url`...
> rmfakecloud could run either on HTTP and HTTPS, so deprecating `STORAGE_URL` in favor of a variable with less information is awkward. you are right - that's why the PR...
Also for me, installed via flatpak ``` /app/bin/element: line 10: 3 Trace/breakpoint trap env TMPDIR="$XDG_RUNTIME_DIR/app/${FLATPAK_ID:-im.riot.Riot}" zypak-wrapper /app/Element/element-desktop $FLAGS "$@" ```
I'm not sure what the better type is, but I think the iterator item type should be the same as the argument type ofFdSet::insert, so that the implementation would be...
`src/poll.rs` has a comment why `BorrowedFd` is used as argument type instead f `F: AsFd`, which also applies here, I think: https://github.com/nix-rust/nix/blob/f129095ac6e76505cfa6711cc78e2b5f4430070e/src/poll.rs#L41 AsFd would allow passing an OwnedFd or File,...
> The `FdSet` interfaces indeed have a reason we might document it :)
appart from type issue, I like the idea of the PR: having a way to construct an `FdSet` from an iterable!
It also failed here: https://github.com/nix-rust/nix/actions/runs/8700433252/job/23860623409?pr=2374 on #2374 I think this test is ok, but sigprocmask races with ALL tests using thread signal masks, as on OSX, sigprocmask sets the mask...
maybe #2375 fixes it, but without a reliable way to reproduce it, its hard to tell