Joey Peter

> This whole proposal is very memory expensive. Reminder, we're running on Android (on-device) here. I'm slowly starting to think this on-device goal was a bad idea x) I agree...

> Is the solution proposal fail safe? Something like 1.2.3 would fail against 1.12.34 With YouTubes current versioning system it is. If they change that, of course it won't be...

> I'd suggest using the version parser from the patches (https://github.com/revanced/revanced-patches/blob/main/src/main/kotlin/app/revanced/meta/readme/SemanticVersion.kt) to compare them If that works, no problem yes.

> Disable "disable-fullscreen-panels" patch. In my case this patch causes it I use revanced daily for minimum 2 hours and never experienced this. Cannot reproduce

I still cannot reproduce this behavior. I've included every patch.

Don't use a beta version.

> > Don't use a beta version. > > There is only the beta of v17.32.35 on apkmirror My bad yes you're right. The one who used that version to...

> Please don't forget [this](https://github.com/revanced/revanced-patches/issues/363#issuecomment-1221294808). I assume it will be the general-ads patch. I have all patches enabled and can't reproduce. Including general ads.

> I built YT 17.36.37 with manager then I tried the same apk on a Galaxy A10 (Android 11) and a Galaxy A52s 5G (Android 12). > > On the...

> General ads could be faulty and remove it via the litho componenent filter. But only on one device? I'm guessing A/B