revanced-patches-template icon indicating copy to clipboard operation
revanced-patches-template copied to clipboard

bug: playlists hidden by `general-ads` patch

Open HeroGalak opened this issue 2 years ago • 7 comments

Type

Cosmetic

Bug description

In YouTube 17.32.35 beta playlists are not visible

Steps to reproduce

Compile with latest revaced files and open the playlist tab

Relevant log output

#

Screenshots or videos

Bug screenshot: Screenshot_20220819-201658_YouTube

Solution

No response

Additional context

No response

HeroGalak avatar Aug 20 '22 09:08 HeroGalak

Please disable patches until the error is gone, report back which one causes this.

oSumAtrIX avatar Aug 20 '22 11:08 oSumAtrIX

Don't use a beta version.

TheJeterLP avatar Aug 20 '22 12:08 TheJeterLP

Don't use a beta version.

There is only the beta of v17.32.35 on apkmirror

HeroGalak avatar Aug 20 '22 12:08 HeroGalak

Don't use a beta version.

There is only the beta of v17.32.35 on apkmirror

My bad yes you're right. The one who used that version to bump the YouTube version made that mistake. Anyways, I'm using that version and cannot reproduce your issue

TheJeterLP avatar Aug 20 '22 12:08 TheJeterLP

Please don't forget this. I assume it will be the general-ads patch.

oSumAtrIX avatar Aug 20 '22 12:08 oSumAtrIX

Please don't forget this. I assume it will be the general-ads patch.

I have all patches enabled and can't reproduce. Including general ads.

TheJeterLP avatar Aug 20 '22 12:08 TheJeterLP

Please disable patches until the error is gone, report back which one causes this.

https://photos.app.goo.gl/NkyatZ7HdQ9eoYRe6

Tried it multiple times, for me it's the Remove general ads.

shivanshvermak avatar Aug 23 '22 01:08 shivanshvermak

I built YT 17.36.37 with manager then I tried the same apk on a Galaxy A10 (Android 11) and a Galaxy A52s 5G (Android 12).

On the A10 all the playlists were visible while on the A52s the bug was still there.

Hope this is helpful to fix the issue.

Edit: apk tested on a Galaxy A30s (Android 11) and playlists are visible

HeroGalak avatar Sep 19 '22 14:09 HeroGalak

I built YT 17.36.37 with manager then I tried the same apk on a Galaxy A10 (Android 11) and a Galaxy A52s 5G (Android 12).

On the A10 all the playlists were visible while on the A52s the bug was still there.

Hope this is helpful to fix the issue.

Revanced doesn't modify that playlist view at all

TheJeterLP avatar Sep 19 '22 14:09 TheJeterLP

General ads could be faulty and remove it via the litho componenent filter.

oSumAtrIX avatar Sep 19 '22 14:09 oSumAtrIX

General ads could be faulty and remove it via the litho componenent filter.

But only on one device? I'm guessing A/B

TheJeterLP avatar Sep 19 '22 14:09 TheJeterLP

I've been having this problem but I noticed that disabling the "Hide suggestions" option in Ads settings makes it so my playlists are visible again.

whatevenisthat avatar Sep 20 '22 09:09 whatevenisthat

Tested the apk on A52s with "Hide suggestions" setting disabled and playlists are visible.

Screenshot A52s (Android 12) with "Hide suggestions" disabled: image

It seems that YouTube (after v17.29.34) shows playlists in different ways depending on the Android version. So when YTR is on Android 11 "Hide suggestions" setting doesn't affect playlists, while on Android 12 the patch wrongly detects the new playlists section and removes it.

Screenshot A10 (Android 11) with "Hide suggestions" enabled: WhatsApp Image 2022-09-20 at 15 20 48

HeroGalak avatar Sep 20 '22 13:09 HeroGalak

It seems that YouTube (after v17.29.34) shows playlists in different ways depending on the Android version. So when YTR is on Android 11 "Hide suggestions" setting doesn't affect playlists, while on Android 12 the patch wrongly detects the new playlists section and removes it.

Im on the latest YouTube version and on Android 12 and it doesnt remove the section for me, thats weird. That needs to be looked further into 100%

TheJeterLP avatar Sep 20 '22 13:09 TheJeterLP

If it's help, Android 9, Nokia 8. Have same issue where playlists from add to playlist menu are not showing if Remove general ads is enabled. Using recommended YT v17.36.37 from apkmirror.

SpL1Ne avatar Sep 25 '22 14:09 SpL1Ne

Built v17.38.35 and v17.36.37 with manager v0.0.27 and playlists are finally visible (even with hide suggestions enabled).

HeroGalak avatar Sep 30 '22 21:09 HeroGalak