Nick
Nick
I hugely agree with this, Like Stefan I spent many hours trying to figure out why my stepper wouldn't move and was just about to return them as defective. There...
I might be blind but I don't see anywhere you implement the GCode command ``` class SHT3X: def __init__(self, config): self.printer = config.get_printer() self.name = config.get_name().split()[-1] self.reactor = self.printer.get_reactor() self.i2c...
I honestly don't understand why temperature_fan has PID control, PID control is most useful when there is direct control over the process variable (the temperature in this instance). I understand...
The only problem I see with this approach is, generally you want to get AHEAD of cooling. If you turn the fan off as soon as it hits the set...
I definitely understand your use case, but you have to understand the bigger picture with the pull request. Specifically here... [Contributing to Klipper](https://www.klipper3d.org/CONTRIBUTING.html) Part 2 under "What to expect during...
I'm by no means the final approver here, just bringing up the concerns I'm sure are to arise. While I agree with all your criticisms, the thing that stands out...
Is this not what's already covered with temperature_fan? You can set a temperature_fan to check an mcu temp. Example: [temperature_fan SB2040_Fan] pin: sb2040:gpio15 sensor_mcu: sb2040 sensor_type: temperature_mcu cycle_time: 0.010 hardware_pwm:...
Second commit just fixed line lengths that trigged the build check to fail
Self Review Info: 1.) Is the submission free of defects and is it ready to be widely deployed? I have been using this code for nearly a week now and...
Something to be aware of is, previously there was the mentioned drift and you (and I) adjusted our Z offset based on that drift to get a good first layer....