Guillaume Raffin

Results 97 comments of Guillaume Raffin

What does `rate` do? This may be normal, since `scaph_host_energy_microjoules` reports the energy consumed since the previous measurement. And the energy measurements occur at regular intervals.

> Could you write an integration test? Yes, but how do I open the perf event? Do I make the corresponding functions of aya public, or do I add a...

> Sorry, a dependency on what? I think you should make whatever you need public so that your test is representative of real usage. I've used the crate perf_event_open_sys for...

Okay, I've added integration tests! I've made a user-friendly version of `perf_event_open` public, for the purpose of testing _and_ to make the feature available to the users without an additional...

Solution to my aforementioned problem: update bpf-linker by running `cargo install bpf-linker`. I've updated the PR to make the new test pass :)

> > ``` > > /// Returns [`MapError::OutOfBounds`] if `index` is out of bounds, [`MapError::SyscallError`] > > /// if `bpf_map_update_elem` fails. > > pub fn set(&mut self, index: u32, value:...

> My hunch is that we should have two separate types - I don't think it's ever desiderable to call open() and set() on the same map, and having both...

Implemented in 26f7ff42f70f32be90a478a6fb99613cc437bd51 :tada:

I take note of the high demand of this feature ;) The "pterodactyl" editor looks good, indeed, but does it actually add a BOM? I have no idea why it...

Thanks for the files! There is no [BOM](https://en.wikipedia.org/wiki/Byte_order_mark) in them. Hmm, so if it only happens with some mods it might be a bug in those mods. Do the logs...