Dan Kolsoi comments

Results 260 comments of


                                            Dan Kolsoi

Add support for inbounds, nsw, nuw, exact flags

Sorry for missing this issue; if llvm-sys / the underlying C api support it then we should too

Specific error types for errors instead of &'static str

Yes, I agree. This is mostly tech debt from the days before `thiserror` and rust having any sort of good error type guidlines

internal error: entered unreachable code: The given type is not a basic type. (when looking at the operands of a call)

I think we have a MetadataBasicValueEnum which is probably want wherever it's failing

Add builder methods for alignable instructions to add alignment without converting to an InstructionValue.

Might be simpler for PointerValue to have a set_alignment method no? Possibly on the BasicValue trait if it applies to all basic values

[Feature] We should be able to walk through the operands of a call wi…

The code does not work across all LLVM versions and needs to be adjusted accordingly

Add append existing basic block method to context impl

That's really weird. I suppose you could slap #[allow(dead_code)] on it and call it a day

doc.rs fails to build the documentation

I don't think there's a way to fix this. docs.rs makes some assumptions about how docs should be generated which don't really apply to inkwell (ie we need a version...

Getting the symbol size for a 1 byte global might return a value of 0 on Windows (and possibly other targets).

Unfortunately we've never had CI tests running on Windows to keep it up to date. Would be a great addition to the test suitee

[FEATURE] Allow certain types of edits rather than all edits across the board

Yep

Can't spawn with statically borrowed data anymore

Thanks for the quick reply! That does look quite similar. Though weirdly I'm seeing it complain about `AsRef` rather than `Send`. Feel free to close as dupe if you think...