Matt Corallo

Results 227 issues of Matt Corallo

For quite some time, LDK has force-closed channels if the peer sends us a feerate update which is below our `FeeEstimator`'s concept of a channel lower-bound. This is intended to...

There is no way to tell whether a `Balance` is for a coop close or an HTLC or a force-close. We should expose that info.

Once we have a finalized coop close transaction we should consider rebroadcasting it via the channelmonitor, I think.

Take a Friday Leave a Friday

re: #2261 we should also ideally expose what our current dust exposure in a channel *is*

good first issue
Take a Friday Leave a Friday

ddf75afd16 introduced the ability to re-exchange our `ChannelOpen` after a peer disconnects if we didn't complete funding on our end. It did not implement nor consider what would happen if...

While we "shipped" async persistence quite a few releases ago, we've always maintained that it is an alpha feature and has some known (and probably unknown) bugs. This is a...

Basically do https://github.com/lightning/bolts/pull/1163 Almost straight code removal, should be a fun on!

Take a Friday Leave a Friday

Most languages don't support move semantics, so the standard rust builder pattern doesn't work. Worse, the invoice construction builder has a ton of type info that enforces downstream correctness. Realistically,...

The naive issues with running before we have finished chain sync are not an issue - if we step the channel after the peer has broadcasted the peer has revoked...

This could throw off our closing signed stuff, and its just confusing, and already forbidden, so we should just forbid it too. Spec says: ``` if no HTLCs remain in...

blocked on spec
Take a Friday Leave a Friday