Florian Bruhin

Results 1602 comments of Florian Bruhin

Another year has passed since this issue has opened, and I think it's now time to just completely drop Qt 5 together with QtWebKit (#4039). See also: [Dropping qt5-webengine -...

For so-called open [shadow DOMs](https://developer.mozilla.org/en-US/docs/Web/Web_Components/Using_shadow_DOM) ([explanation](https://blog.revillweb.com/open-vs-closed-shadow-dom-9f3d7427d1af?gi=517cca36714b)), it should actually be possible for qutebrowser to access the elements therein. However, I'm a bit confused about what the best way would be...

Support for open shadow DOMs is now implemented in 7315c34957fd3b7c08d3314ba645eafd0eb6a815.

Some refactorings I spotted while looking at this: --- # ✔️ da8428f9ba10da20c039f6c4a4a71d554201e09d https://github.com/qutebrowser/qutebrowser/blob/c9498995df7967a055444ae37e13f583764d238f/qutebrowser/browser/webengine/webenginetab.py#L1624-L1640 should be merged into the `browsertab.py` code (or actually the other way around as the workaround is...

Workaround fixed in f57afa39e8c9dc4b57c95a021af8a588f6c8c822. I still think splitting this across multiple schemes would be a good idea though, so we can lock down custom schemes as much as possible.

@gordon-quad It's not, but see #8785. Already worked around in 31a5737, but waiting for an updated PyQt binary before cutting a release with it.

> is it hard to implement tree style tabs? Hard to say - the basics of indenting pages should be relatively easy, but then there are other things like collapsing/expanding,...

@sitonapanotis You posted your comment ~25 times, I deleted the others now - if you have a customized user agent, you'll need to set it back to the default for...

Some pointers: - New tabs are opened in `def tabopen` in `mainwindow/tabbedbrowser.py` - that already has an `explicit` argument set to `True` if it's a new "group", or `False` if...

@Xananax Thanks for the great overview! This definitely seems less simple to get correct than I initially thought :wink: