Zac Burns

Results 65 comments of Zac Burns
trafficstars

> I think starting with 1.0.0 is ok, but also interested in @That3Percent's expectations of a 1.x release I also think a 1.0.0 release is a good choice. Even if...

The latest `stable-hash` is now merged and published to [crates.io](https://crates.io/crates/stable-hash)! Thanks @lutter for your thorough review. Some things that will need to happen to get this over the finish line:...

@mangas Version 0.4.1 is published to [crates.io](https://crates.io/crates/stable-hash). This patch: - Fixes the intermittent compiler error you were seeing - Supports big endian architectures - Removes all `unsafe` - Updates to...

@mangas Here are the best examples for implementing the `StableHash` trait: [enum](https://github.com/graphprotocol/stable-hash/blob/cfffede2605152f4147130489afac4ec921c73cb/tests/profiling.rs#L152), [struct](https://github.com/graphprotocol/stable-hash/blob/cfffede2605152f4147130489afac4ec921c73cb/tests/profiling.rs#L187)

@mangas Unblocked. Did a PR review and responded to issue in Slack.

@dizzyd Yep. This got deferred for graph-day but I took it back up soon after. There's a WIP that was posted Friday here: https://github.com/graphprotocol/graph-node/pull/3678 All that is left on my...

@dizzyd @mangas: The PR is ready for review

@mangas: You can find the places that need to change to switch on the new algorithm by searching for `a0a79c0f-919f-4d97-a82 a-439a1ff78230`. There are only two instances.

@azf20 @mangas Let's hold off on merging this. I'd like to make a small improvement which may unlock some protocol improvements. I would like to have the finalization step include...

Yes, I think manually implementing the traits is the way to go here.